Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 shell integration not working #176

Closed
przet opened this issue Aug 31, 2019 · 6 comments
Closed

Windows 10 shell integration not working #176

przet opened this issue Aug 31, 2019 · 6 comments

Comments

@przet
Copy link

przet commented Aug 31, 2019

In Windows10 v1809 (OS build 17763.678) and v1903 (OS build 18362.295), the explorer integration does not work. You can see the WinMerge option in context menu when selecting >=1 files, but WinMerge does not open at all.

For WinMerge version 2.16.4.0 x86

@przet
Copy link
Author

przet commented Aug 31, 2019

I would also like to work on this one please :)

I am going to test on a couple other Win10 machines, and also eliminate any anti-virus program issues (which in my experience has created issues in other applications), and then get stuck into the code if needed.

Would be interesting to hear if anyone else has spotted this issue on Win10

@przet
Copy link
Author

przet commented Sep 3, 2019

@przet
Copy link
Author

przet commented Sep 3, 2019

Working in my v1809 windows now. Suspected restart was required, however can't reproduce on my v1903 windows.

@przet przet changed the title Windows 10 file explorer integration not working Windows 10 shell integration not working Sep 3, 2019
@sdottaka
Copy link
Member

sdottaka commented Sep 3, 2019

Thank you for the report.

I could reproduce the bug when unchecked 'Launch WinMerge' checkbox in the installer as follows

image

Did you uncheck the checkbox too?

@przet
Copy link
Author

przet commented Sep 7, 2019

@sdottaka yes - when checked on my WinMerge version shell integration works. I am still not sure why it started to work as mentioned in my previous comment, even though I did not check the box.

@sdottaka
Copy link
Member

sdottaka commented Sep 7, 2019

The reason WinMerge does not start from ShellExtension is that the WinMege path is not set in the registry key HKEY_CURRENT_USER\Software\Thingamahoochie\WinMerge\Executable.

The above registry key is set once WinMerge is started, so you probably have started WinMerge from something other than ShellExternsion.

@sdottaka sdottaka closed this as completed Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants