Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winmerge crashes consistently when deleting files #491

Closed
jrmain opened this issue Nov 26, 2020 · 7 comments
Closed

Winmerge crashes consistently when deleting files #491

jrmain opened this issue Nov 26, 2020 · 7 comments

Comments

@jrmain
Copy link

jrmain commented Nov 26, 2020

Up until the last couple of weeks, I never had problems like this with Winmerge; it's always been very reliable. Thanks for that!

But recently, when comparing folders, if I select several that are 'only on the right side', right click, and choose to delete them on the right side, Winmerge crashes.

After this happened earlier today, I compared the same folders and again tried to delete those same folders, and again Winmerge crashed.

When this happens, the selected folders are not deleted.

Not sure if it matters, but I usually perform comparisons like this by right-clicking a folder in Explorer and choosing 'Compare To' , then right-clicking the other folder and choosing 'Compare'.

I'm running Winmerge 2.16.8.0, currently the latest version. According to my notes, the last time I updated Winmerge was September 4, 2020, but it's possible I failed to record subsequent updates.

I've attached the configuration log as requested.
WinMerge.txt

I also tested this by comparing two folders that were identical except for a small text file in a new folder in one of the folders. When I right-clicked the 'right side only' folder in Winmerge and selected 'Delete on right side', I got a message: 'Out of Memory'. After clicking the OK button on the error dialog, Winmerge became unresponsive and started using 100% of one CPU core. I had to terminate it.

@sdottaka
Copy link
Member

I haven't been able to reproduce this bug yet.

I would appreciate it if you could let me know the conditions for reproducing the bug.

@jrmain
Copy link
Author

jrmain commented Nov 28, 2020

What kind of additional information are you looking for? Running processes? A screencast of the sequence of steps leading up to the problem?

@jrmain
Copy link
Author

jrmain commented Nov 28, 2020

Here's the app crash report for the most recent crash.
WinmergeAppcrashReport.txt

@sdottaka
Copy link
Member

Thank you for the information.

I tried to reproduce the bug in Windows 8.1 on a virtual machine using your WinMerge.txt settings, but the bug could not be reproduced.

Can you tell me if you have the following information?

- WinMergeU.exe.*.dmp file in %appdata%\local\CrashDumps
- The name of the compared folders and the path name of the file you were trying to delete

@jrmain
Copy link
Author

jrmain commented Nov 29, 2020

I attached a ZIP file containing three dump files.
WinMergeU.exe.13716.zip

Folders I'm comparing:
F:\Download\ISS\Bazar_Wordpress_Theme_3.15.0\bazar\bazar-child
F:\Download\ISS_bazar-child_from_dev_site

Folder (and the file it contains) that I'm trying to delete:
F:\Download\ISS_bazar-child_from_dev_site\test
F:\Download\ISS_bazar-child_from_dev_site\test\test.txt

@sdottaka
Copy link
Member

Now I can reproduce the problem with your information.
There was a problem under the following conditions.

  • Enable Include Subfolders option
  • Non-tree mode
  • When a folder containing a file is deleted

I've fixed the bug with commit 44dd52a.

Thank you for the report!

@jrmain
Copy link
Author

jrmain commented Nov 30, 2020

Excellent! Happy to help. Looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants