Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap panes not working for 3 file comparison.... #507

Closed
4evermaat opened this issue Dec 13, 2020 · 6 comments
Closed

swap panes not working for 3 file comparison.... #507

4evermaat opened this issue Dec 13, 2020 · 6 comments

Comments

@4evermaat
Copy link

The swap panes feature only works properly with 2-file comparisons. 3 file comparisons, the middle file always remains the same when trying to swap. I cannot swap middle file.

The problem is that I cannot customize the middle file when initiating the comparison from windows explorer (selecting 3 files in windows explorer, and then using context menu to launch in WinMerge).

Would be nice to drag/drop OR to pop up (drop-down) a menu that would allow user to customize which file goes into which pane, without having to start over with new manual comparison.

Please fix this.

@ranjwarrior
Copy link
Contributor

I can work on this and submit a PR, unless someone is already working on this. My proposal is:

  1. Modify the View -> Swap Panes to View -> Swap Panes -> <3 new menus Swap 1-2, Swap 2-3 and Swap1-3>
  2. The Swap Pane functionality (currently only swaps first and last) will account for the file index and swap the panes between fromIndex and ToIndex as long as ToIndex >2
    Will wait for confirmation before proceeding (sorry am new here)
    SwapPanes

@sdottaka
Copy link
Member

sdottaka commented Jan 1, 2021

Great! We welcome your pull requests.

@ranjwarrior
Copy link
Contributor

Created the PR - sorry if I missed anything. Also I don't seem to have the permission to link the PR to this issue. Thx.

@sdottaka
Copy link
Member

sdottaka commented Jan 2, 2021

Fixed by PR #533

@sdottaka sdottaka closed this as completed Jan 2, 2021
@ranjwarrior
Copy link
Contributor

ranjwarrior commented Jan 2, 2021 via email

@sdottaka
Copy link
Member

sdottaka commented Jan 2, 2021

There was nothing wrong with it.
I had to update the .po file because some strings that needed to be translated were added, but the .po files are updated automatically at build time, so it's not a hassle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants