Various fixes to testing #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* I have no idea why Git thinks this is necessary
* If the `...-x64-PerUser-Setup.exe` file is missing from the `Build/` folder tree, then GuiTests fails with a) a system message box suggesting a file name misspelling, plus b) seven ASSERT failures that have to be manually Ignored * This patch allows GuiTests to detect the missing file itself and cause a proper GTEST_FAIL() action. * The filename for the Setup.exe file is upgraded from version `2.16.7.0` to `2.16.8` (the latest publicly available setup file that I could find)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
?? Bring FreeImage submodule into sync ??
Fix syntax errors with
Testsolution configurationGetMainFrame()->FileNew()procedure, but not incorporated into the code for theTestconfiguration.Fix Failures with GuiTests
InstallerTestmoduleIf the
...-x64-PerUser-Setup.exefile is missing from theBuild/folder tree, then GuiTests fails witha) A message box (from deep within the
system()function) suggesting a file name misspelling, plusb) Seven
ASSERTfailures that have to be individually, manually Ignored.This patch allows GuiTests to detect the missing file itself and cause a proper
GTEST_FAIL()action.
The filename for the required
...Setup.exefile is upgraded from version2.16.7.0to2.16.8(the latestpublicly available setup file that I could find).