Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to set up default highlighting by a file extension #627

Merged

Conversation

tjmprm77
Copy link
Contributor

This PR adds a feature to set up default highlighting by a file extension talked about in discussion #542.

- Add features to SubeditList.
  - Specify read-only columns.
  - Add Wildcard drop list as an editing style.
  - Specify the character limit. (Currently valid only when the editing style is Wildcard drop list.)
- Tweak Wildcard drop list.
  - Deselect the string and move the caret to the end of the string when opening the drop list.
  - Apply the input string when the drop list is closed by mouse operation after inputting the extension from the keyboard.
- Change the CrystalLineParser::TextDefinition extension delimiter from comma to semicolon.
  (That's because Wilcard drop list requires a semicolon as the delimiter.)
- Change CrystalLineParser::GetTextType(const TCHAR* pszExt) to check if the extension matches the text type "Plain" at the end.
  (The file type extension setting UI does not include the text type "Plain".
  So, when assigning the extension originally assigned to "Plain" such as "txt" to another file type, the check for that file type must be done before "Plain".)
- Add a sheet to the options dialog to set default highlighting by file extension. (Editor > Syntax)
- Add processing to reload syntax highlighting setup when option setting is completed.
@sdottaka sdottaka merged commit 706a5e9 into WinMerge:master Feb 12, 2021
@sdottaka
Copy link
Member

Great! Thank you!

@mlipok
Copy link
Contributor

mlipok commented Feb 13, 2021

Plans for release ?

@sdottaka
Copy link
Member

sdottaka commented Feb 13, 2021

I want to release new versions three or four times a year, but I haven't set a specific release date.

If you want a binary that includes this feature, please download it below.

https://ci.appveyor.com/project/sdottaka/winmerge/build/artifacts

@mlipok
Copy link
Contributor

mlipok commented Feb 13, 2021

Thanks will test this feature.
btw.
I want to ask if It contains all changes from latest release ?

@sdottaka
Copy link
Member

the link above always points to installers built from the latest source code.

@mlipok
Copy link
Contributor

mlipok commented Feb 13, 2021

Is that mean that always when you commit new change to main source, then always you make a working installer which could be found on this provided link ?

@sdottaka
Copy link
Member

sdottaka commented Feb 13, 2021

Installers will be created automatically by AppVeyor when pushing commits to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants