Fix issue 106 #114
Merged
Fix issue 106 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, ensured the execute_shell method would throw a proper WinRMInvalidShell exception if passed an invalid shell type.
WinRMCommunicator execute method now properly respects the error_check options argument. If this is true an exception will be thrown, which is what core Vagrant expects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match core Vagrant functionality the execute method was changed to respect the error_check argument and raise an exception when set to true.
This makes some core Vagrant error messages accurate, such as when Vagrant attempts to test if the Puppet executable exists on the guest.