Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Parallels provider #154

Merged
merged 1 commit into from
Dec 16, 2013
Merged

Compatibility with Parallels provider #154

merged 1 commit into from
Dec 16, 2013

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Dec 16, 2013

This commit adds compatibility with Parallels provider
I've checked it by myself and all existing features is working fine for this environment:

  • Vagrant 1.4.0
  • 'vagrant-parallels' v0.1.0
  • Parallels Desktop 8 and 9
  • Host: OS X 10.9
  • Guest: Windows Server 2012 R2

P.s. I'm ready to support this compatibility in future.

@legal90
Copy link
Contributor Author

legal90 commented Dec 16, 2013

Just one notice: while using Parallels provider, you should not put the forwarded_port rule into Vagrantfile, because our provider does not support port forwarding.
But provider is detecting guest's IP correctly, you can just skip this string and everything will work fine.

@sneal
Copy link
Member

sneal commented Dec 16, 2013

This change looks good, thanks!

Any idea if this would work with Parallels 7? I ask because that's the version I have.

sneal added a commit that referenced this pull request Dec 16, 2013
Compatibility with Parallels provider
@sneal sneal merged commit c37f385 into WinRb:master Dec 16, 2013
@sneal
Copy link
Member

sneal commented Dec 16, 2013

Released vagrant-windows 1.5 gem with Parallels support.

@legal90
Copy link
Contributor Author

legal90 commented Dec 16, 2013

Any idea if this would work with Parallels 7?

Unfortunatly, vagrant-parallels works only with Parallels Desktop 8 and higher. The reason is that prlctl utility in PD 7 has not option '--json' for machine-readable output and we have not done the backward compatibility yet (Parallels/vagrant-parallels#33).

@sneal
Copy link
Member

sneal commented Dec 16, 2013

That's OK, if I start using Parallels more often I'll probably upgrade it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants