Fix windows shell provisioner #45
Conversation
This commit adds monkey_patches to make shell provisioner to work on windows. Fix mkdir parameter mkdir parameter did not work properly
|
I'll take a look at this PR this week. |
|
Thanks |
|
@patux Which syntax are you using in your Vagrantfiles with the shell provisioner? External script path or inline? config.vm.provision :shell, :path => "script.ps1" |
|
@sneal always external, if the script is internal there is no extensión... so that part will likely fail, cause windows will not know which interpreter to use to execute c:\tmp\vagrant-shell, but that is what is happening right now... I haven't figure out how to improve that.. but right now to me is a minor issue.... I do preffer to have something working that nothing working. |
|
inline scripts will definitely fail. External scripts look like they might fail too since I believe this is pulling the file extension off the temp file and not the source script. I'm going to work on this today, I need the ability to use inline scripts. |
|
mmmm I did tests with two different scritps.. (ps1, and .bat) , and it worked.. Let me know if I can help |
|
I used this PR and extended it to support inline shell scripts. |
This patch fixes issue: #38