Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix simple typo, routeable -> routable #47

Closed
wants to merge 1 commit into from
Closed

docs: fix simple typo, routeable -> routable #47

wants to merge 1 commit into from

Conversation

timgates42
Copy link

There is a small typo in src/msrpc-server.c, src/network.c.

Should read routable rather than routeable.

There is a small typo in src/msrpc-server.c, src/network.c.

Should read `routable` rather than `routeable`.
@rouben
Copy link
Collaborator

rouben commented Nov 17, 2020

Thanks for the patch, @timgates42. Unfortunately, this is merely a mirror of the original project, which is distributed through this post on the MDL forums (note: registration is required for access). I've made attempts to convince the author of this software to publish this project and be more open to accepting patches such as yours through GitHub or a similar platform, however, I received quite a bit of pushback.

Long story short, merging this patch would mean that we will be deviating from upstream, which AFAIK, is a private SubVersion (or maybe nowadays it's git or hg?) repository used exclusively by the author.

I'll leave it up to @Wind4, the owner of this project to decide if this is the direction we want to take this project in. If the community wants to maintain a fork with community improvements, it means that someone from the community would then have to backport the patches from the fork to the upstream when the original developer of this project releases updates. These releases don't happen very often (usually once a year), but regardless of the release schedule, backporting will be an ongoing issue unless the upstream author chooses to be more openly collaborative.

@timgates42 timgates42 closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants