Pointwatch Abyssea time remaining

[mordth]

The time remaining feature in the pointwatch lua executes a running total versus the actual time remaining. Fix is easy. Change line 291 from:
abyssea.time_remaining = abyssea.time_remaining + p1

to
abyssea.time_remaining = p1

[Nifim]

Line 291 is for when the status is extended, the others currently do = p1

    visitant_status_gain = function(p1,p2,p3,p4)
        abyssea.time_remaining = p1
    end,
    visitant_status_update = function(p1,p2,p3,p4)
        abyssea.time_remaining = p1
    end,
    visitant_status_wears_off = function(p1,p2,p3,p4)
        abyssea.time_remaining = p1
    end,
    visitant_status_extend = function(p1,p2,p3,p4)
        abyssea.time_remaining = abyssea.time_remaining + p1
    end,

is the extend p1 now equal to the total time?

[mordth]

It is equal to the actual time remaining. As the code is written, every time you get a time extension, it adds the new time remaining to the previous time remaining. Ie 210 minutes becomes 430 minutes with the addition of a 10 minute time extension (210+220=430). This continues indefinitely leading to a nonsensical output.

…

On Mon, Nov 23, 2020 at 3:40 PM Nifim ***@***.***> wrote: Line 291 is for when the status is extended visitant_status_gain = function(p1,p2,p3,p4) abyssea.time_remaining = p1 end, visitant_status_update = function(p1,p2,p3,p4) abyssea.time_remaining = p1 end, visitant_status_wears_off = function(p1,p2,p3,p4) abyssea.time_remaining = p1 end, visitant_status_extend = function(p1,p2,p3,p4) abyssea.time_remaining = abyssea.time_remaining + p1 end, is the extend p1 now equal to the total time? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1972 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHCOFXR4BEQEXEDVYJGXKSLSRLCEVANCNFSM4T77EO2Q> .