Create device for User - EXTRA: set boolean for Admin in User schema #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnoFleming
suggested changes
Mar 27, 2017
| @@ -0,0 +1,5 @@ | |||
| FactoryGirl.define do | |||
There was a problem hiding this comment.
If you're not using it, remove it!
There was a problem hiding this comment.
using it now and added factory for user
| @@ -0,0 +1,5 @@ | |||
| require 'rails_helper' | |||
| t.string :email, null: false, default: "" | ||
| t.string :encrypted_password, null: false, default: "" | ||
| # created extra boolean whether user is admin or not | ||
| t.boolean :admin, default: false |
There was a problem hiding this comment.
Please create test to expose/ensure that a user won't be an admin by default (as it is important business logic). Also, add a test to show your colleagues how to add an admin user to the system.
|
@arnoFleming , it should be better now. |
|
please label me @leefreemanxyz ! |
spec/models/user_spec.rb
Outdated
| expect(guest_user.admin).to eq(false) | ||
| end | ||
|
|
||
| it "the 'Admin' status is false" do | ||
| it "if 'Admin' status is set to true by another Admin, |
There was a problem hiding this comment.
I think we could describe this test as : 'it "creates an admin user when admin: true is included in the create function" '
There was a problem hiding this comment.
@lee, changed it according to your suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created devise for user with extra: Admin boolean - standard to false