Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt real app to generator #276

Conversation

EvgenySmekalin
Copy link
Collaborator

No description provided.

@@ -65,7 +69,7 @@ def generate_openapi(
paths[url_path_without_prefix] = path_item

info = Info(title=title, version=version, description=description)
servers_ = [Server(**server) for server in servers or []]
servers_ = [Server(**server) for server in servers or []] or [Server(url=path_prefix)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to discuss how to handle servers parameter

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tags

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an approve blocker

for inspector in get_route_parameters_inspectors():
inspector_class = inspector.__class__

if inspector_class in inspector_classes:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why duplicates are possible?

@mofr mofr marked this pull request as ready for review July 8, 2023 09:24
@mofr mofr merged commit e01db2a into WinterFramework:issues-241-get-rid-of-drf-yasg Jul 8, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants