Apply pointcloud, continued #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit warning if config still provides no ignored "wiener_threshold_tag". Also remove the utterly rediculous and afaic find totally unused 50 argument long constructor.
This uncovers the problem that wclsFrameSaver in larwirecell uses the "threshold" tag to both loate the wiener RMS summary and to save it into the art::Event. For now I have left this, until understanding how best to handle it. If we also change this to "wiener" it has downstream consequences on any consumer of the art::Event.
…vor of "wiener". WARNING to art/larsoft users: The wclsFrameSaver uses this tag both to find traces and to save a vector<double> data product in the art::Event. This commit changes how wclsFrameSaver is configured. There are to implications: 1) You may have your own configuration of wclsFrameSaver. It MUST use "wiener" to find Wiener RMS summary as "threshold" does no longer exist. 2) Any art/larsoft code downstream must look for these values in "wiener" and not "threshold". If all goes well, any old configuration will cause art/larsoft to exist quickly and loudly so it should be easy to find the configuration that needs updating.
Note, some tests fail. Merge my apply-pointcloud first to see if they are already fixed
A test name change broke history-comp1d.bats. I need to regenerate data repo
General solution is inbound
This is intended to be used as part of a test for tiling. The tenio test runs it and we get something out, but more work is still needed. Note, there is also a much older BlobReframer, (which really takes ICluster). It is broken in the case that the blobs have lost their connection with their original frame, such as when they are read from file.
… reframe from blobs without an IFrame available
…arning of missing rcrc
Some change in test-noise-roundtrip.bats needs checking. Still need to tune test-wct-uboone-img.bats failure threshold
|
Some of the checklist is not done - and more is needed - but we decided to get this in before moving on to the clustering stage of the porting. |
|
Compiles and runs for both uboone and FD-VD. Compared to uboone ref: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues the work started in #217.
ICluster(seeBlobSamplingandBlobSampler)util/test/doctest_eigen_pca.cxx)util/test/doctest_pointcloud_hough.cxx)BlobSetReframer)The main test is
img/test/test-tenio.{org,bats}and thetenio-*.jsonnetfiles in same dir.