forked from brettviren/wire-cell-toolkit
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lmn resampling #273
Draft
brettviren
wants to merge
17
commits into
master
Choose a base branch
from
lmn-resampling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Lmn resampling #273
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e0167dd - Browse repository at this point
Copy the full SHA e0167ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for c639076 - Browse repository at this point
Copy the full SHA c639076View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e99a68 - Browse repository at this point
Copy the full SHA 9e99a68View commit details -
Configuration menu - View commit details
-
Copy full SHA for c233810 - Browse repository at this point
Copy the full SHA c233810View commit details
Commits on Jan 31, 2024
-
Get mostly full test in place.
Still need to implemente resampling in NF instead of just python
Configuration menu - View commit details
-
Copy full SHA for a559842 - Browse repository at this point
Copy the full SHA a559842View commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7422230 - Browse repository at this point
Copy the full SHA 7422230View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcce41b - Browse repository at this point
Copy the full SHA fcce41bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ed45fc - Browse repository at this point
Copy the full SHA 3ed45fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e580a - Browse repository at this point
Copy the full SHA a8e580aView commit details
Commits on Feb 6, 2024
-
Explicitly get all traces on input.
Prior, Digitizer took all untagged traces. These two should be equivalent in the context of simulation. In the, until now nonexistent, case of reading a voltage frame from a FrameFileSink-produced file, the '*' bets (mis)interpreted to be a trace tag instead of being a wild card and this caused Digitizer to not get any traces. The entire situation with frame and trace tags is a big jumbled and deserves to be straightened out globally. But, for now, this makes things work and really tags have no place in simulation so should be correct going foward.
Configuration menu - View commit details
-
Copy full SHA for 1ddcdee - Browse repository at this point
Copy the full SHA 1ddcdeeView commit details
Commits on Feb 7, 2024
-
- Add artifact mitigation to Resampler via different time-domain padding strategies. - Add a CLI Jsonnet to run just the Resampler. - Move from a BATS test to a Snakemake file to run everything as it is starting to get complex.
Configuration menu - View commit details
-
Copy full SHA for ab86c76 - Browse repository at this point
Copy the full SHA ab86c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2b8669 - Browse repository at this point
Copy the full SHA c2b8669View commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 239e208 - Browse repository at this point
Copy the full SHA 239e208View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0a7a3d5 - Browse repository at this point
Copy the full SHA 0a7a3d5View commit details
Commits on Mar 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 525f54b - Browse repository at this point
Copy the full SHA 525f54bView commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2de13d0 - Browse repository at this point
Copy the full SHA 2de13d0View commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf9981a - Browse repository at this point
Copy the full SHA bf9981aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.