Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix threshold related bugs #280

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

HaiwangYu
Copy link
Member

Some are not bugs. But some are. Simple note attached. May need a better one.
2024-03-12_threshold.pdf

  • fix typo, switch wiener gauss
  • only save to threshold for wiener
  • change default Magnify summary op to set as we only used it for RMS
  • change default magnify.jsonnet threshold label.

@brettviren
Copy link
Member

Note, the test added for #220 checks for this regression of adding back thresholds.

Here is it running on the merge of mine any your apply-pointcloud branch.

❯ bats test/test/test-issue220.bats
test-issue220.bats
 ✗ no wiener_threshold_tag in cfg
   tags: issue:220
   (in test file test/test/test-issue220.bats, line 16)
     `[[ -z "$found" ]]' failed
   found with wiener_threshold_tag:
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/sp.jsonnet:      wiener_threshold_tag: 'threshold%d' % anode.data.ident,
 ✗ no threshold tags in cfg - this fails until wclsFrameSaver issue resolved
   tags: issue:220
   (in test file test/test/test-issue220.bats, line 26)
     `[[ -z "$found1" ]]' failed
   found with 'threshold' tags:
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/wcls-sim-drift-simchannel.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel-omit-noise.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),
   /home/bviren/dev/wct/imaging/toolkit/cfg/pgrapher/experiment/icarus/wcls-multitpc-sim-drift-simchannel.jsonnet:  sp_thresholds: wcls.output.thresholds(name='spthresholds', tags=['threshold']),

2 tests, 2 failures

@HaiwangYu HaiwangYu merged commit bb53a1c into WireCell:master Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants