Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running WireMock.Net as a sub-app in IIS #164

Merged
merged 9 commits into from Jul 17, 2018
Merged

Support running WireMock.Net as a sub-app in IIS #164

merged 9 commits into from Jul 17, 2018

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Jul 15, 2018

No description provided.

@StefH StefH requested a review from DavidKorn July 15, 2018 06:03
@codecov
Copy link

codecov bot commented Jul 15, 2018

Codecov Report

Merging #164 into master will increase coverage by 0.38%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   69.39%   69.78%   +0.38%     
==========================================
  Files          83       85       +2     
  Lines        3029     3068      +39     
  Branches      413      417       +4     
==========================================
+ Hits         2102     2141      +39     
  Misses        753      753              
  Partials      174      174
Impacted Files Coverage Δ
src/WireMock.Net/Server/FluentMockServer.cs 50% <0%> (-0.41%) ⬇️
src/WireMock.Net/Models/UrlDetails.cs 100% <100%> (ø)
src/WireMock.Net/Admin/Requests/LogRequestModel.cs 100% <100%> (ø) ⬆️
src/WireMock.Net/Util/UrlUtils.cs 100% <100%> (ø)
src/WireMock.Net/Owin/OwinRequestMapper.cs 96.87% <100%> (ø) ⬆️
src/WireMock.Net/RequestMessage.cs 97.53% <100%> (+0.19%) ⬆️
src/WireMock.Net/Serialization/LogEntryMapper.cs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e9eadf...0323c23. Read the comment docs.

@StefH
Copy link
Collaborator Author

StefH commented Jul 15, 2018

@DavidKorn - Can you review and approve so that this PR can me merged to main.

@StefH StefH added the feature label Jul 16, 2018
Copy link
Collaborator

@DavidKorn DavidKorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Read through these changes, and we've already been using this preview version. Thanks.

@StefH StefH self-assigned this Jul 17, 2018
@StefH StefH merged commit a9c0c6b into master Jul 17, 2018
@StefH StefH deleted the iis_fix branch July 19, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants