Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor restclient (WireMock.Net version 1.1.x) #312

Closed
wants to merge 20 commits into from
Closed

Refactor restclient (WireMock.Net version 1.1.x) #312

wants to merge 20 commits into from

Conversation

StefH
Copy link
Collaborator

@StefH StefH commented Aug 5, 2019

No description provided.

@StefH StefH added the feature label Aug 5, 2019
@StefH StefH self-assigned this Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019 •
edited

Codecov Report

Merging #312 into master will decrease coverage by <.01%.
The diff coverage is 91.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   79.94%   79.94%   -0.01%     
==========================================
  Files         110      110              
  Lines        4379     4363      -16     
==========================================
- Hits         3501     3488      -13     
+ Misses        878      875       -3
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 94.44% <ø> (ø) ⬆️
src/WireMock.Net/RequestMessage.cs 93.1% <ø> (ø) ⬆️
...et/Matchers/Request/RequestMessageHeaderMatcher.cs 96.29% <ø> (ø) ⬆️
...k.Net.Abstractions/Models/Mappings/MappingModel.cs 100% <ø> (ø)
...WireMock.Net/Server/FluentMockServer.AdminFiles.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockNullLogger.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Server/FluentMockServer.cs 69.3% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockConsoleLogger.cs 0% <ø> (ø) ⬆️
....Net.Abstractions/Models/Settings/SettingsModel.cs 100% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 76.81% <ø> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dd9e1...5bde870. Read the comment docs.

4 similar comments
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #312 into master will decrease coverage by <.01%.
The diff coverage is 91.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   79.94%   79.94%   -0.01%     
==========================================
  Files         110      110              
  Lines        4379     4363      -16     
==========================================
- Hits         3501     3488      -13     
+ Misses        878      875       -3
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 94.44% <ø> (ø) ⬆️
src/WireMock.Net/RequestMessage.cs 93.1% <ø> (ø) ⬆️
...et/Matchers/Request/RequestMessageHeaderMatcher.cs 96.29% <ø> (ø) ⬆️
...k.Net.Abstractions/Models/Mappings/MappingModel.cs 100% <ø> (ø)
...WireMock.Net/Server/FluentMockServer.AdminFiles.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockNullLogger.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Server/FluentMockServer.cs 69.3% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockConsoleLogger.cs 0% <ø> (ø) ⬆️
....Net.Abstractions/Models/Settings/SettingsModel.cs 100% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 76.81% <ø> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dd9e1...5bde870. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #312 into master will decrease coverage by <.01%.
The diff coverage is 91.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   79.94%   79.94%   -0.01%     
==========================================
  Files         110      110              
  Lines        4379     4363      -16     
==========================================
- Hits         3501     3488      -13     
+ Misses        878      875       -3
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 94.44% <ø> (ø) ⬆️
src/WireMock.Net/RequestMessage.cs 93.1% <ø> (ø) ⬆️
...et/Matchers/Request/RequestMessageHeaderMatcher.cs 96.29% <ø> (ø) ⬆️
...k.Net.Abstractions/Models/Mappings/MappingModel.cs 100% <ø> (ø)
...WireMock.Net/Server/FluentMockServer.AdminFiles.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockNullLogger.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Server/FluentMockServer.cs 69.3% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockConsoleLogger.cs 0% <ø> (ø) ⬆️
....Net.Abstractions/Models/Settings/SettingsModel.cs 100% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 76.81% <ø> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dd9e1...5bde870. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #312 into master will decrease coverage by <.01%.
The diff coverage is 91.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   79.94%   79.94%   -0.01%     
==========================================
  Files         110      110              
  Lines        4379     4363      -16     
==========================================
- Hits         3501     3488      -13     
+ Misses        878      875       -3
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 94.44% <ø> (ø) ⬆️
src/WireMock.Net/RequestMessage.cs 93.1% <ø> (ø) ⬆️
...et/Matchers/Request/RequestMessageHeaderMatcher.cs 96.29% <ø> (ø) ⬆️
...k.Net.Abstractions/Models/Mappings/MappingModel.cs 100% <ø> (ø)
...WireMock.Net/Server/FluentMockServer.AdminFiles.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockNullLogger.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Server/FluentMockServer.cs 69.3% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockConsoleLogger.cs 0% <ø> (ø) ⬆️
....Net.Abstractions/Models/Settings/SettingsModel.cs 100% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 76.81% <ø> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dd9e1...5bde870. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #312 into master will decrease coverage by <.01%.
The diff coverage is 91.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   79.94%   79.94%   -0.01%     
==========================================
  Files         110      110              
  Lines        4379     4363      -16     
==========================================
- Hits         3501     3488      -13     
+ Misses        878      875       -3
Impacted Files Coverage Δ
src/WireMock.Net/Owin/WireMockMiddleware.cs 94.44% <ø> (ø) ⬆️
src/WireMock.Net/RequestMessage.cs 93.1% <ø> (ø) ⬆️
...et/Matchers/Request/RequestMessageHeaderMatcher.cs 96.29% <ø> (ø) ⬆️
...k.Net.Abstractions/Models/Mappings/MappingModel.cs 100% <ø> (ø)
...WireMock.Net/Server/FluentMockServer.AdminFiles.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockNullLogger.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Server/FluentMockServer.cs 69.3% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockConsoleLogger.cs 0% <ø> (ø) ⬆️
....Net.Abstractions/Models/Settings/SettingsModel.cs 100% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 76.81% <ø> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19dd9e1...5bde870. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 5, 2019 •
edited

Codecov Report

Merging #312 into master will increase coverage by 0.14%.
The diff coverage is 63.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage    80.5%   80.65%   +0.14%     
==========================================
  Files         114      114              
  Lines        4566     4544      -22     
==========================================
- Hits         3676     3665      -11     
+ Misses        890      879      -11
Impacted Files Coverage Δ
src/WireMock.Net/RequestMessage.cs 93.1% <ø> (ø) ⬆️
...et/Matchers/Request/RequestMessageHeaderMatcher.cs 96.29% <ø> (ø) ⬆️
...k.Net.Abstractions/Models/Mappings/MappingModel.cs 100% <ø> (ø)
src/WireMock.Net/Logging/WireMockNullLogger.cs 100% <ø> (ø) ⬆️
src/WireMock.Net/Util/BodyParser.cs 96.9% <ø> (ø) ⬆️
src/WireMock.Net/Logging/WireMockConsoleLogger.cs 0% <ø> (ø) ⬆️
...bstractions/Models/Scenarios/ScenarioStateModel.cs 0% <ø> (ø)
....Net.Abstractions/Models/Settings/SettingsModel.cs 100% <ø> (ø)
src/WireMock.Net/Serialization/MappingConverter.cs 77.62% <ø> (ø) ⬆️
...k.Net/ResponseProviders/DynamicResponseProvider.cs 100% <ø> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2167f8...4278d45. Read the comment docs.

@StefH StefH mentioned this pull request Sep 6, 2019
Closed
@StefH StefH closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@StefH StefH

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@StefH