Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blacklist for Request Cookies. #319

Merged
merged 3 commits into from Aug 19, 2019

Conversation

vitaliydavydiak
Copy link
Contributor

Refactor code. Fix tests.

Refactor code. Fix tests.
Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 tests fail, please fix these

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 2 tests fail, please fix these
  • and see other comment

@StefH
Copy link
Collaborator

StefH commented Aug 17, 2019

A question:

currently the blacklisted headers and cookies are just a string array.

Wouldn't it be better if an array/collection of IStringMatcher would be allowed. When using a IStringMatcher, more complex matching like Wildcard or Regex are possible. What are your thoughts?

@vitaliydavydiak
Copy link
Contributor Author

A question:

currently the blacklisted headers and cookies are just a string array.

Wouldn't it be better if an array/collection of IStringMatcher would be allowed. When using a IStringMatcher, more complex matching like Wildcard or Regex are possible. What are your thoughts?

Not sure if it brings that much value. Headers and Cookies are pretty unique and well-known so defining exact names collection is ok. Most likely you want to filter all that out.

@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #319 into master will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   79.94%   79.93%   -0.02%     
==========================================
  Files         110      111       +1     
  Lines        4379     4420      +41     
==========================================
+ Hits         3501     3533      +32     
- Misses        878      887       +9
Impacted Files Coverage Δ
src/WireMock.Net.StandAlone/StandAloneApp.cs 0% <0%> (ø) ⬆️
src/WireMock.Net/Server/FluentMockServer.Admin.cs 61.61% <100%> (+0.4%) ⬆️
...rc/WireMock.Net/Settings/ProxyAndRecordSettings.cs 100% <100%> (ø) ⬆️
src/WireMock.Net/Matchers/LinqMatcher.cs 83.33% <0%> (-16.67%) ⬇️
src/WireMock.Net/Owin/WireMockMiddleware.cs 94.44% <0%> (ø) ⬆️
src/WireMock.Net/Matchers/XPathMatcher.cs 89.28% <0%> (ø) ⬆️
src/WireMock.Net/Owin/MappingMatcher.cs 100% <0%> (ø) ⬆️
src/WireMock.Net/Owin/MappingMatcherResult.cs 100% <0%> (ø)
src/WireMock.Net/Server/FluentMockServer.cs 69.6% <0%> (+0.3%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfd72c...236ff3b. Read the comment docs.

Copy link
Collaborator

@StefH StefH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@StefH
Copy link
Collaborator

StefH commented Aug 19, 2019

A new NuGet will be created in some time...

@StefH StefH merged commit 4c74d1a into WireMock-Net:master Aug 19, 2019
@vitaliydavydiak vitaliydavydiak deleted the blacklist-for-cookies branch August 19, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants