Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding netcoreapp3.1 as a target framework #509

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Adding netcoreapp3.1 as a target framework #509

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
525ac4d
Adding netcoreapp3.0 and netcoreapp3.1 as a target framework
APIWT Sep 29, 2020
275dbe7
Expanding NETSTANDARD check to include ASP.NET Core targets
APIWT Sep 29, 2020
aa7b1d0
End of life netcoreapp3.0 changes and using NETCOREAPP3_1 instead of …
APIWT Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WireMock.Net/Http/HttpClientHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ internal static class HttpClientHelper
{
public static HttpClient CreateHttpClient(IProxyAndRecordSettings settings)
{
#if NETSTANDARD
#if NETSTANDARD || USE_ASPNETCORE
APIWT marked this conversation as resolved.
Show resolved Hide resolved
var handler = new HttpClientHandler
{
CheckCertificateRevocationList = false,
Expand Down
2 changes: 1 addition & 1 deletion src/WireMock.Net/Matchers/CSharpCodeMatcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ private bool IsMatch(dynamic input, string pattern)
throw new WireMockException("CSharpCodeMatcher: Problem calling method 'IsMatch' in WireMock.CodeHelper", ex);
}

#elif (NETSTANDARD2_0 || NETSTANDARD2_1)
#elif (NETSTANDARD2_0 || NETSTANDARD2_1 || USE_ASPNETCORE)
APIWT marked this conversation as resolved.
Show resolved Hide resolved
dynamic script;
try
{
Expand Down
10 changes: 8 additions & 2 deletions src/WireMock.Net/WireMock.Net.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<Description>Lightweight Http Mocking Server for .Net, inspired by WireMock from the Java landscape.</Description>
<AssemblyTitle>WireMock.Net</AssemblyTitle>
<Authors>Stef Heyenrath</Authors>
<TargetFrameworks>net451;net452;net46;net461;netstandard1.3;netstandard2.0;netstandard2.1</TargetFrameworks>
<TargetFrameworks>net451;net452;net46;net461;netstandard1.3;netstandard2.0;netstandard2.1;netcoreapp3.0;netcoreapp3.1</TargetFrameworks>
APIWT marked this conversation as resolved.
Show resolved Hide resolved
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<AssemblyName>WireMock.Net</AssemblyName>
<PackageId>WireMock.Net</PackageId>
Expand Down Expand Up @@ -42,7 +42,7 @@
<DefineConstants>NETSTANDARD;USE_ASPNETCORE</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp2.1' or '$(TargetFramework)' == 'netcoreapp2.2'">
<PropertyGroup Condition="'$(TargetFramework)' == 'netcoreapp2.1' or '$(TargetFramework)' == 'netcoreapp2.2' or '$(TargetFramework)' == 'netcoreapp3.0' or '$(TargetFramework)' == 'netcoreapp3.1'">
APIWT marked this conversation as resolved.
Show resolved Hide resolved
<DefineConstants>USE_ASPNETCORE</DefineConstants>
</PropertyGroup>

Expand Down Expand Up @@ -135,6 +135,12 @@
<PackageReference Include="CS-Script.Core" Version="1.3.1" />
</ItemGroup>

<ItemGroup Condition=" '$(TargetFramework)' == 'netcoreapp3.0' or '$(TargetFramework)' == 'netcoreapp3.1'">
APIWT marked this conversation as resolved.
Show resolved Hide resolved
<FrameworkReference Include="Microsoft.AspNetCore.App" />
<!-- https://github.com/WireMock-Net/WireMock.Net/issues/448 -->
<PackageReference Include="CS-Script.Core" Version="1.3.1" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\WireMock.Net.Abstractions\WireMock.Net.Abstractions.csproj" />
</ItemGroup>
Expand Down