Change search indexes to Haystack #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brylie
reviewed
Jun 6, 2017
|
|
||
| text = indexes.CharField(document=True) | ||
|
|
||
| from wirecloud.commons.haystack_backends.solr_backend import GroupedSolrSearchBackend |
There was a problem hiding this comment.
PEP-8 recommends that:
Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants.
What is the reason to import GroupedSolrSearchBackend within the CatalogueResourceIndex class definition?
There was a problem hiding this comment.
You are right, it should be at the top.
Currently, its there as a placeholder while we look for a better solution that does not require to use a different field depending on the searching back-end.
Mognom
changed the title
added 26 commits
October 31, 2017 10:37
added 16 commits
October 31, 2017 10:43
added 12 commits
October 31, 2017 12:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all indexes to use Haystack in order to support multiple search backends.
Haystack does not support grouping, so it has to be added. This is used for
catalogueresourcequeries