-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] (ja) Add Japanese Translation #396
Conversation
Hi @fisuda, Thank you very much for your contribution! and sorry for delay on the response.
I've been testing and your translations seems not to be affecting tutorials. I think that you problems with tutorials are, probably, not related to the translations itself but with some bug on the tutorials code. Are the tutorial working for you using the english language? What browser are you using for testing?
I've merged you changes regarding this widget (Wirecloud/workspace-browser-widget#3), maybe you are not seeing the changes as we have to update this widget within WireCloud. But seems to be working: If you are using the development settings, please ensure you have Japanese enable: LANGUAGES = (
('es', 'Spanish'),
('en', 'English'),
('pt', 'Portuguese'),
('ja', 'Japanese'),
) |
Hi @aarranz, Thank you so much for taking your precious time for me. Sorry for lacking my environment information.
My Wirecloud instance is build using 'docker-wirecloud / dev'. I set my repository and branch in the Dockerfile.
I have tested again.
Unfortunately, I haven't been able to reproduce it. This issue was occurred on the condition the widgets haven't been uploaded yet. I will try to check the occurrence condition again.
The following errors are occurred on the Chrome browser after selecting the menu. And then, the tutorial don't start.
The following message remains in English. I think that the Mashup API returns this message. But, I haven't been able to find the cause. 'We couldn't find anything for your search' |
6a6f071
to
e7b69ec
Compare
Hi @aarranz, I found the cause for two problems. Please have a look.
It seems that this problem is not related to the translations. The following error occurs when using localhost or 127.0.0.1 as a host address.
This problem was due to a translation error. e7b69ec |
Hi @aarranz,
These error messages have been able to localize to Japanese by updating Workspace Browser widget. The three issues have been solved. Would you please review this PR? |
Hi @fisuda, On the one hand, I've updated the workspace browser widget to version 0.1.3 on the WireCloud repo 😄. On the other hand, We've made some updates into the WireCloud repo and I think that some of those changes has modified some messages, could you check if you have to make some update to the Japanese translation? Once updated or confirmed that nothing has to be changed, I'll merge this PR. Good work 😉. |
Hi @aarranz, As I'm on my way from Genoa to Tokyo, now I can't work on this. Sorry, I will check if you have to make some update, and reply to you on Saturday. Thank you. |
Hi @aarranz, I apologize for the late reply. I updated Japanese messages. Please review this PR. |
I think it is ok, so I merged it. I'll work on releasing WireCloud 1.3 in the next weeks (probably in two weeks), so I will notify you if a see any problem. Thank you very much! |
Hi @aarranz ,
I'm trying to make Wirecloud supporting Japanese language.
Although I made Japanese message files, I encountered the following issues while testing.
Please give me a advice.
Thanks