Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for json-based widgets/mashups #532

Closed
wants to merge 0 commits into from

Conversation

dmunozv04
Copy link
Contributor

Proposed changes

Implements the necessary changes so json-based widgets/mashups can be loaded/created in wirecloud.
Creates mashups using a config.json properties file.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

"I have read the CLA Document and I hereby sign the CLA"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dmunozv04
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 88.945% (+0.02%) from 88.923%
when pulling 6473bd0 on dmunozv04:develop
into 28fec83 on Wirecloud:develop.

@dmunozv04
Copy link
Contributor Author

This PR depends on the #534 PR since it already parses V2 config files.
It would be interesting to change the config file to something unique instead of config.json so the JSON Schema can be sent to Schema Store to allow verifying the config file inside IDEs.

dmunozv04 pushed a commit to dmunozv04/wirecloud that referenced this pull request Mar 25, 2024
@dmunozv04 dmunozv04 closed this Mar 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants