Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors showing on console when Wirecloud is loaded as an iframe #536

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

oxixes
Copy link
Contributor

@oxixes oxixes commented Mar 10, 2024

Proposed changes

If Wirecloud was loaded as an iframe, some errors would show up in the console. This simple fix solves that problem by making the window object behave as if it wasn't in an iframe.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

None

@coveralls
Copy link

Coverage Status

coverage: 88.984%. remained the same
when pulling cf0349f on oxixes-patch-1
into 01e171a on develop.

@aarranz aarranz merged commit 247b900 into develop Mar 14, 2024
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants