Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for json-based widgets/mashups #540

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dmunozv04
Copy link
Contributor

Proposed changes

Implements the necessary changes so json-based widgets/mashups can be loaded/created in wirecloud.
Creates mashups using a config.json properties file. Adds a jsonschema validator

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

It would be interesting to change the config file to something unique instead of config.json so the JSON Schema can be sent to Schema Store to allow verifying the config file inside IDEs. Reopening this PR since the last one had some issues with files from another branch

@coveralls
Copy link

Coverage Status

coverage: 88.991%. first build
when pulling fb76d2c on dmunozv04:json-support
into 247b900 on Wirecloud:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants