Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Timing out on login #2

Open
hunvreus opened this issue Aug 10, 2016 · 6 comments
Open

[BUG] Timing out on login #2

hunvreus opened this issue Aug 10, 2016 · 6 comments
Assignees

Comments

@hunvreus
Copy link
Member

When trying to log in, the OAuth request times out. I'm unable to test the app. Two things;

  • We need the loading animation to be display (see Loading transitions #1 ) until the page loads.
  • If it fails, it'd be nice to have a way of displaying something nicer than an empty/grey page (default branded message?)

Let me know if we can fix it @Jamesford @EcutDavid

@EcutDavid
Copy link
Contributor

Let's wait staging deployed.

@hunvreus
Copy link
Member Author

Could we also switch to prod URLs? Like fullpm.com?

@Jamesford
Copy link
Contributor

Looked into this a bit, GitHub's CSP prevents iframes from rendering their "login with github" pages.

Is it possible to change the login <button> to an <a> tag with an href? And have that open in a new tab? Or if the login went through a popup instead of redirection perhaps that would work?

@Jamesford
Copy link
Contributor

Jamesford commented Aug 10, 2016

Change of plans, it appears that I can make a request to https://staging-fullpm.wiredcraft.net/auth/user via the extension to check if the user is logged in. If they click the boards button and are not logged in, I can redirect them to login instead of opening the tab.

Additionally, I can add an onInstalled function to the extension to redirect them to login immediately. So I will also do that.

And finally we can also include a login link on the Extension menu, (the thing that pops up when you click the extension icon on chromes url bar) but we currently don't use that feature so I'll hold off on that until we add that to the extension.

@Jamesford
Copy link
Contributor

Jamesford commented Aug 10, 2016

Finished the logic for a user clicking the "Board" tab button but isn't logged in. We redirect to the github authorization page, after accepting authorization it redirects back to the previous page with the board tab open.

@Jamesford
Copy link
Contributor

Jamesford commented Aug 10, 2016

Requests login on installing the extension too, opens a new tab and redirects to https://github.com after logging-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants