Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build arm based macOS builds natively #1135

Merged
merged 1 commit into from Feb 8, 2024

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented Feb 7, 2024

Now that GitHub officially has an M1 macOS runner available, it's much better to build arm builds natively on the macos-14 runner. Results in way faster and much more stable builds. Completes in about 4 minutes compared to the previous 10 minutes. All of the prebuilds currently supported by BS3 were tested on this runner at better-sqlite3-multiple-ciphers.

It might also be possible to build emulated builds (arm64 on Linux) on this runner much faster, together with Docker buildx. I'll look into that also, as soon as I have some time.

@m4heshd m4heshd requested review from JoshuaWise and a team as code owners February 7, 2024 01:09
Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@mceachen mceachen merged commit 2dabc23 into WiseLibs:master Feb 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants