-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Electron 1.4 (V8 5.3.X) #3
Conversation
Thanks for the PR! It is indeed important to support the I believe the only way to detect the v8 version is with |
Cool sounds good - I'll update the PR! |
It might be a good idea to rebase this branch with a7a6d65, so the changes from #4 (comment) are included. |
I've cleaned up and rewritten much of the ancient history that was in |
This PR replaces the
get/setHiddenValue
APIs with the new V8 Private APIs. I actually wasn't able to find what version introduced them, and I'm not sure if it's important to continue supporting them when Private is not available. Using the private APIs took a few more lines of code, so it might be nice to create a convenience function if both need to be supported.I also found that node-bindings was unable to resolve the module's root when running in Electron. This line returns undefined: https://github.com/TooTallNate/node-bindings/blob/master/bindings.js#L55.
This PR should resolve #2!