Move repetitive build commands into environment variables #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mceachen
requested changes
Apr 11, 2023
mceachen
added a commit
to mceachen/better-sqlite3
that referenced
this pull request
Apr 11, 2023
Co-authored-by: mceachen <mceachen@users.noreply.github.com>
mceachen
added a commit
that referenced
this pull request
Apr 19, 2023
…)" This reverts commit c88ca6d.
|
Apologies! Somehow my branch forgot the @m4heshd if you create a PR from master...mceachen:better-sqlite3:fix-broken-989 I can approve it and get it merged. |
m4heshd
added a commit
to m4heshd/better-sqlite3
that referenced
this pull request
Apr 19, 2023
* Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com>
mceachen
added a commit
that referenced
this pull request
Apr 19, 2023
* Move repetitive build commands into environment variables (#989) * Move repetitive build commands into environment variables * Merge 'https://github.com/mceachen/better-sqlite3/tree/dry-gha-989' Co-authored-by: mceachen <mceachen@users.noreply.github.com> --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> * restore "env." prefixes to NODE_BUILD_CMD and ELECTRON_BUILD_CMD --------- Co-authored-by: mceachen <mceachen@users.noreply.github.com> Co-authored-by: Matthew McEachen <matthew@photostructure.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unnecessary to have the same, base build command fully written for each job.