Dialog windows of modules crash application

[dmarszk]

According to Wisling, any child afx window opened by dialog window ends up crashing TA.

[dmarszk]

I'm actually finding it hard to reproduce when using eaca85d as head. @Wisling please advise.

[Wisling]

I checked and it's only in the debug build of TA.

[dmarszk]

Could you provide me with steps to reproduce?

2016-04-05 14:44 GMT+02:00 Wisling notifications@github.com:

I checked and it's only in the debug build of TA.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1 (comment)

[Wisling]

Yeah, if you don't experience it, then let me know.
Build TA under Debug.
Run TA & connect to any Tibia session.
Go to spells, healing, and try and edit the exura sio Heal List. If there is an error before the window appears, then that's what I'm referring to.

[dmarszk]

Thanks.
I found the culprit. All modules are being derived from CWinApp. It's pointless, because all modules are actually DLLs acting as hidden dialogs. CWinApp makes MFC think each module is a separate application, and tries to assign the child dialog boxes to it. I'll fix it after merging current patches.

[dmarszk]

Fixed in d08e5d8

[Wisling]

That probably explains why tabbing didn't work either. I may need to undo some work-arounds :P