Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Sigma detections since v1.1.0 #30

Closed
einarssonm opened this issue Oct 24, 2021 · 1 comment
Closed

Incorrect Sigma detections since v1.1.0 #30

einarssonm opened this issue Oct 24, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@einarssonm
Copy link

Potential bug resulting in incorrect Sigma detections since Chainsaw v1.1.0.

When parsing a System.evtx file with Chainsaw v1.1.0 (from "chainsaw_x86_64-pc-windows-msvc.zip"), several Sigma rules are incorrectly triggered by every 7045 event. See example below:

image

A similar test using Chainsaw v1.0.2 shows no false positives, see below:

image

Finally a test with Chainsaw v1.0.2 using the Sigma rule set bundled with v1.1.0. No false positives, see below:

image

@fscc-jamesd
Copy link
Contributor

fscc-jamesd commented Oct 24, 2021

@einarssonm - Thanks for raising this, good spot! I think I know why this is happening, In v1.1.0 I fixed an issue where event IDs were being converted to string values before comparison. Now that this issue is fixed I think the comparison is being done correctly but this has potentially surfaced an issue with how chainsaw converts Sigma rules.

Looking at the raw sigma logic for the sigma rules in your screenshot we can see they contain the logic block below which I think is causing these false-positives:

---
logsource:
  ¦ product: windows
  ¦ service: system
detection:
  ¦ selection:
  ¦ ¦ ¦ EventID: 7045
---

I've reverted the Event ID conversion changes and released v1.1.1 for the time being until I can write a proper fix. I'll close this issue for now, but please feel free to let me know if v1.1.1 hasn't fixed this issue in the interim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants