Add testing into Chainsaw #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also contains some refactoring that was required to open up chainsaw so that we can start testing properly. As a result we have a little bit of pub leaking going on here. But this will be addressed affter the rest of the tests are written.
|
Code tests for hunt/search are too hard to plug in without rework. For now we will tests these with scripts on the complete binary, so that we can ensure that nothing is broken when the refactor is started. |
These are not permanent tests, the script is very very basic. Its sole purpose is to allow for a chainsaw refactor. These diffs will allow for extensive changes to be made with assurance that the output is still correct. Once the refactor is done there should be sufficient native testing that this e2e suite will not need expansion.
|
Have added a crude script that will diff the output of chainsaw. This will enable the refactor as we can be certain that we are not regressing the code. |
fscc-jamesd
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for us to grow Chainsaw and look after it we need to add tests which were skipped on release due to timing constraints. I have added the most important ones first.
Once all of the above is done, then the big refactor in prep for 2.0 can begin.