Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/seperate json attributes #54

Merged
merged 1 commit into from Jan 9, 2022
Merged

Fix/seperate json attributes #54

merged 1 commit into from Jan 9, 2022

Conversation

fscc-jamesd
Copy link
Contributor

This PR resolves #51

@fscc-jamesd fscc-jamesd mentioned this pull request Jan 7, 2022
Closed
fscc-alexkornitzer
fscc-alexkornitzer suggested changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@fscc-alexkornitzer fscc-alexkornitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the commits need squashing too before this is merged IMO.

src/hunt/modules.rs Outdated Show resolved Hide resolved
@fscc-jamesd fscc-jamesd self-assigned this Jan 7, 2022
@fscc-jamesd fscc-jamesd merged commit e117c17 into master Jan 9, 2022
@fscc-jamesd fscc-jamesd deleted the fix/seperate_json_attributes branch January 9, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fscc-alexkornitzer fscc-alexkornitzer fscc-alexkornitzer approved these changes

Assignees

@fscc-jamesd fscc-jamesd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use separate-json-attributes
2 participants
@fscc-jamesd @fscc-alexkornitzer