Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of spaces in tex backslash extensions #399

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Fix handling of spaces in tex backslash extensions #399

merged 5 commits into from
Jan 31, 2024

Conversation

lostenderman
Copy link
Collaborator

Closes #386.

Witiko
Witiko previously approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@Witiko Witiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Let's just extend the test files with the examples for display math in addition to inline math.

tests/testfiles/lunamark-markdown/tex-math-double-backslash.test Outdated Show resolved Hide resolved
tests/testfiles/lunamark-markdown/tex-math-double-backslash.test Show resolved Hide resolved
tests/testfiles/lunamark-markdown/tex-math-single-backslash.test Outdated Show resolved Hide resolved
tests/testfiles/lunamark-markdown/tex-math-single-backslash.test Show resolved Hide resolved
@Witiko Witiko marked this pull request as ready for review January 31, 2024 10:35
@Witiko Witiko added bug syntax extension Related to syntax extensions and dialects of markdown automerge This pull request will be automatically merged after continuous integration has succeeded labels Jan 31, 2024
@Witiko Witiko added this to the 3.4.0 milestone Jan 31, 2024
@Witiko Witiko force-pushed the fix-tex-backslash-extensions branch from 9aef499 to 0ac80c5 Compare January 31, 2024 10:41
@github-actions github-actions bot merged commit fb24af4 into Witiko:main Jan 31, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Witiko Witiko Witiko approved these changes

Assignees
No one assigned
Labels
automerge This pull request will be automatically merged after continuous integration has succeeded bug syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Make options tex_single_backslash_math and tex_double_backslash_math robust against extra spaces
2 participants
@lostenderman @Witiko