forked from jgm/lunamark
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make appending operator more efficient and use it in testing framework #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in <#437 (comment)>. Co-Authored-By: Enrico Gregorio <Enrico.Gregorio@univr.it>
Witiko
added
plaintex
Related to the plain TeX interface and implementation
technical debt
Related to code smells and refactoring
expl3
Related to the high-level programming language expl3
speed
Related to speed improvements
labels
Apr 25, 2024
Previously, we would store the definitions in `\l_tmpa_tl`, which would be overriden during a call to `\@@_tl_from_cs:NNn`.
Witiko
force-pushed
the
feat/make-appending-operator-more-efficient
branch
from
April 25, 2024 21:06
19ab5ac
to
baa08f8
Compare
As discussed in <#437 (comment)>. Co-Authored-By: Max Chernoff <mseven@telus.net>
… empty parameters"" This reverts commit 7bf0fc5.
Witiko
changed the title
Make appending operator more efficient
Make appending operator more efficient and use it in testing framework
Apr 27, 2024
As discussed with @Skillmon in <https://tex.stackexchange.com/q/716362/70941#comment1781373_716400>. Co-Authored-By: Jonathan P. Spratte <jspratte@yahoo.de>
Witiko
force-pushed
the
feat/make-appending-operator-more-efficient
branch
from
April 28, 2024 09:34
d3529f4
to
5465557
Compare
Witiko
force-pushed
the
feat/make-appending-operator-more-efficient
branch
from
April 28, 2024 17:24
e278bf2
to
dc40518
Compare
Witiko
added a commit
to Witiko/latex3
that referenced
this pull request
Apr 28, 2024
As discussed at the following places: - <https://tex.stackexchange.com/q/716362/70941> - <Witiko/markdown#437> - <Witiko/markdown#438> Co-Authored-By: Enrico Gregorio <Enrico.Gregorio@univr.it> Co-Authored-By: Max Chernoff <mseven@telus.net> Co-Authored-By: Jonathan P. Spratte <jspratte@yahoo.de>
Witiko
added a commit
to Witiko/latex3
that referenced
this pull request
Apr 28, 2024
As discussed at the following places: - <https://tex.stackexchange.com/q/716362/70941> - <Witiko/markdown#437> - <Witiko/markdown#438> Co-Authored-By: Enrico Gregorio <Enrico.Gregorio@univr.it> Co-Authored-By: Max Chernoff <mseven@telus.net> Co-Authored-By: Jonathan P. Spratte <jspratte@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
expl3
Related to the high-level programming language expl3
plaintex
Related to the plain TeX interface and implementation
speed
Related to speed improvements
technical debt
Related to code smells and refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #437.