Mw accessible overlay #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wittmaxi
force-pushed
the
MW_accessible_overlay
branch
2 times, most recently
from
bd680bc
to
60c411e
Compare
Wittmaxi
force-pushed
the
MW_accessible_overlay
branch
2 times, most recently
from
d06e356
to
292d692
Compare
Wittmaxi
force-pushed
the
MW_accessible_overlay
branch
3 times, most recently
from
8020ff1
to
69f2c8e
Compare
Reintroduces Icons for opening/closing the replace area of the overlay. fixes eclipse-platform#1960
- The icons are part of a local toolbar. Therefore move them from the "obj" folder to the "lcl16" folder. - Fix file name for high resolution icons for select_prev and select_prev icons - Make more clear what's the file name of and icon and what's it's key Fixes: eclipse-platform#1977
If command is null a NPE occurs even though from the code it seems this should be handled by a fallback. This replaces Optional.of with Optional.ofNullable to account for that case.
* remove unnecessary casts
Wittmaxi
force-pushed
the
MW_accessible_overlay
branch
from
69f2c8e
to
54609c8
Compare
Returns functionality whereby open projects _and_ non-project resources get the 'refresh' contextual menu (option was removed for non-project resources via the fix @ eclipse-platform/eclipse.platform#876 ).
TriggeredOperations.getTriggeringOperation() can return null after TriggeredOperations.remove() eclipse-platform#2004
Wittmaxi
force-pushed
the
MW_accessible_overlay
branch
2 times, most recently
from
0676bfe
to
9f4a2cd
Compare
…e-platform#1919 Replace the FocusListener with a ShellAdapter which will remove the search scope as soon as the overlay is left. The FocusListener didn't listen to the case where the focus is in the search bar and the search bar is left (and the overlay is left implicitly) fixes eclipse-platform#1919
HeikoKlare
force-pushed
the
MW_accessible_overlay
branch
from
9f4a2cd
to
41f69f2
Compare
…orm#1910 Makes the Find/Replace Overlay options accessible by tabbing through the different option buttons. Implements a new "AccessibleToolBar" class which wraps the ToolBar and allows for being natively accessible by using the normal traversal mechanism provided by SWT. fixes eclipse-platform#1910
HeikoKlare
force-pushed
the
MW_accessible_overlay
branch
from
41f69f2
to
7642988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.