Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the touch listener from being added every time the disable scrolling method is called #1

Merged
merged 5 commits into from
Mar 7, 2014

Conversation

polco
Copy link

@polco polco commented Feb 17, 2014

@@ -10,6 +10,7 @@ function WuiView() {
WuiDom.call(this);
this.assign('div', { className: 'WuiView' });
this.hideMethod();
this._hasTouchListener = false;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but that's way too generic a name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would _scrollingListenerAdded be ok?

On Mon, Feb 17, 2014 at 4:51 PM, Ron Korving notifications@github.comwrote:

In index.js:

@@ -10,6 +10,7 @@ function WuiView() {
WuiDom.call(this);
this.assign('div', { className: 'WuiView' });
this.hideMethod();

  • this._hasTouchListener = false;

Sorry, but that's way too generic a name.

Reply to this email directly or view it on GitHubhttps://github.com//pull/1/files#r9784012
.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need it at all if we have scrollingDisabled?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While scrollingDisabled is undefined, it's not being used. Otherwise, it's true or false.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is if we start by using the "enable" method, then the
scrollingDisabled
is defined and the listener is never added if the "disable" method is then
called.

On Mon, Feb 17, 2014 at 7:25 PM, Ron Korving notifications@github.comwrote:

In index.js:

@@ -10,6 +10,7 @@ function WuiView() {
WuiDom.call(this);
this.assign('div', { className: 'WuiView' });
this.hideMethod();

  • this._hasTouchListener = false;

While scrollingDisabled is undefined, it's not being used. Otherwise, it's
true or false.

Reply to this email directly or view it on GitHubhttps://github.com//pull/1/files#r9787321
.

micky2be added a commit that referenced this pull request Mar 7, 2014
Keep the touch listener from being added every time the disable scrolling method is called
@micky2be micky2be merged commit 91b99cb into WizUI:master Mar 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants