Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we initialize the login callback from fbDidLogin so it is still #15

Merged
merged 5 commits into from Sep 16, 2011

Conversation

dokterbob
Copy link
Contributor

Make sure we initialize the login callback from fbDidLogin so it is still fired when loggin in from non-multitasking environments. Fixes #14.

@dokterbob
Copy link
Contributor Author

Meanwhile, I have merged your latest changes into my fork and removed some of the xcode slug you accidently checked in - it's safely ignored from now on.

Also, I noticed you moved the login to Facebook's request didLoad, which seems to make a lot less sense than having it in didLogin - which is where I put it (and where it seems to work just fine).

Lastly, I am wondering why you think it is a sensible design decision to automatically request the uid after logging in, per se? As mobile requests are quite costly and we should be perfectly able to do this explicitly, this seems to be unnecessary - but maybe I have missed something.

Anyways, thanks for writing up such a great product, anyways. :)

@davejohnson
Copy link

Having a look at this. I am not an obj-c pro so bear with me :)

The reason that I make the request for the uid is so that everything works as per the FB JS SDK. In the normal JS SDK the session object contains the uid once logged in, so just trying to keep it the same. I talked to guys at FB and this is the best / only way until they provide the uid in the native mobile SDK's.

@shazron
Copy link
Contributor

shazron commented Sep 15, 2011

hi @dokterbob you need to rebase your pull-request branch before this can be auto merged through Github. thanks

@dokterbob
Copy link
Contributor Author

@shazron There you go. Also (accidentally) merged in a patch which more rigorously gets rid of some of the XCode leftovers in the example (a follow-up on b57793f and 79dc5cd).

shazron added a commit that referenced this pull request Sep 16, 2011
Make sure we initialize the login callback from fbDidLogin so it is still
@shazron shazron merged commit 1654d61 into Wizcorp:master Sep 16, 2011
slachkar pushed a commit to PopSugar/phonegap-facebook-plugin that referenced this pull request Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facebook login for iOS 4.2.1 broken
3 participants