New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure we initialize the login callback from fbDidLogin so it is still #15
Conversation
…till fired when loggin in from non-multitasking environments.
Conflicts: native/ios/FacebookConnectPlugin.m
Meanwhile, I have merged your latest changes into my fork and removed some of the xcode slug you accidently checked in - it's safely ignored from now on. Also, I noticed you moved the login to Facebook's request didLoad, which seems to make a lot less sense than having it in didLogin - which is where I put it (and where it seems to work just fine). Lastly, I am wondering why you think it is a sensible design decision to automatically request the uid after logging in, per se? As mobile requests are quite costly and we should be perfectly able to do this explicitly, this seems to be unnecessary - but maybe I have missed something. Anyways, thanks for writing up such a great product, anyways. :) |
Having a look at this. I am not an obj-c pro so bear with me :) The reason that I make the request for the uid is so that everything works as per the FB JS SDK. In the normal JS SDK the session object contains the uid once logged in, so just trying to keep it the same. I talked to guys at FB and this is the best / only way until they provide the uid in the native mobile SDK's. |
hi @dokterbob you need to rebase your pull-request branch before this can be auto merged through Github. thanks |
Make sure we initialize the login callback from fbDidLogin so it is still
App Invites and update to SDK 4.4
Make sure we initialize the login callback from fbDidLogin so it is still fired when loggin in from non-multitasking environments. Fixes #14.