don't build flutter SDK artifacts for armv7 (flutter#28016)

WizzXu · Nov 5, 2021 · ed66091 · ed66091
1 parent dadc7b2
commit ed66091
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/BUILD.gn b/BUILD.gn
@@ -46,8 +46,11 @@ if (flutter_prebuilt_dart_sdk) {
 
 # Flutter SDK artifacts should only be built when either doing host builds, or
 # for cross-compiled desktop targets.
+# TODO: We can't build the engine artifacts for arm (32-bit) right now;
+# see https://github.com/flutter/flutter/issues/74322
 _build_engine_artifacts =
-    current_toolchain == host_toolchain || (is_linux && !is_chromeos) || is_mac
+    current_toolchain == host_toolchain ||
+    (is_linux && !is_chromeos && current_cpu != "arm") || is_mac
 
 group("dart_sdk") {
   if (_build_engine_artifacts) {

diff --git a/tools/gn b/tools/gn
@@ -88,7 +88,7 @@ def is_host_build(args):
     # target_os='linux' and linux-cpu='arm64'
     # TODO(fujino): make host platform explicit
     #   https://github.com/flutter/flutter/issues/79403
-    return args.target_os is None or args.target_os == 'linux'
+    return args.target_os is None or (args.target_os == 'linux' and args.linux_cpu == 'arm64')
 
 # Determines whether a prebuilt Dart SDK can be used instead of building one.
 # We can use a prebuilt Dart SDK when: