Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beforeDestroy fix #36

Merged
merged 1 commit into from Jun 16, 2017
Merged

beforeDestroy fix #36

merged 1 commit into from Jun 16, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 16, 2017

beforeDestroy hook placed by mistake inside methods block?

@sleewoo
beforeDestroy fix
848f76e 
`beforeDestroy` hook placed by mistake inside `methods` block?
@coveralls
Copy link

Coverage Status

Coverage increased (+3.0%) to 67.662% when pulling 848f76e on sleewoo:patch-1 into ccfd31f on Wlada:master.

Wlada
Wlada approved these changes Jun 16, 2017
View reviewed changes
Copy link
Owner

@Wlada Wlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sleewoo , you are right. Thanks for creating a pull request.

@Wlada Wlada merged commit 00a33a2 into Wlada:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@coveralls @Wlada @sleewoo