Fix JavaScript error when using TagsInputWidget #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DE_JQUERY is enabled.
wolph
added a commit
that referenced
this pull request
Mar 7, 2014
Fix JavaScript error when using TagsInputWidget
|
Thank you very much for the fix, I guess I already had jQuery running when I tested this locally :) |
wolph
added a commit
that referenced
this pull request
May 24, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
TagsInputFieldin a form andTAGS_INPUT_INCLUDE_JQUERYis enabled, Chome on OS X throws this JavaScript error:It's because the tagsinput plugin's script is loaded before jQuery itself is. Tweaking the
TagsInputWidgetclass to make sure the plugin is loaded after jQuery fixes the issue.