Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.rst: Trim outdated .EXCLUSIVE snippets #75

Merged
merged 1 commit into from Feb 17, 2022

Conversation

joshuacwnewton
Copy link
Contributor

@joshuacwnewton joshuacwnewton commented Feb 16, 2022

I was following the documentation for this project for the first time, but this section confused me a little. It looks like these bits of the documentation got duplicated somehow?

I've kept only the portalocker.LOCK_EX snippet, since it seems to be the only valid flag presently.

It looks like these sections got duplicated somehow. I've kept only the portalocker.LOCK_EX snippet, since it seems to be the only valid flag presently.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f5823f8 on joshuacwnewton:patch-1 into b47d5f4 on WoLpH:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f5823f8 on joshuacwnewton:patch-1 into b47d5f4 on WoLpH:develop.

@wolph
Copy link
Owner

wolph commented Feb 17, 2022

Thank you for the fix :)

That's indeed an oversight during one of the cleanup/refactorings
The EXCLUSIVE flag actually still exists, but it's part of the LockFlags structure so I'll update the documentation with your fix

@wolph wolph merged commit b6d4409 into wolph:develop Feb 17, 2022
@joshuacwnewton joshuacwnewton deleted the patch-1 branch February 17, 2022 03:58
@joshuacwnewton
Copy link
Contributor Author

Thank you for the quick response! My apologies for missing that .EXCLUSIVE is still valid (I tried the snippets as-is and got an error, so I assumed). But, I very much appreciate the clarification. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants