Progress emulation in Windows 10 (doesnt work)

[ilwsm]

This code not update text in console

All time this: N/A% | | 0.0 s/B 0.0 B/300.0 B Elapsed Time: 0:00:00 ETA: --:--:--

import collections
import time
import progressbar

struct = collections.namedtuple

def get_progress_info():
    """Return a function callback to update the progressbar."""
    progressinfo = struct("ProgressInfo", ["callback", "finish"])

    if progressbar:
        bar = progressbar.ProgressBar(widgets=[
            progressbar.Percentage(),
            ' ', progressbar.Bar(),
            ' ', progressbar.FileTransferSpeed(),
            ' ', progressbar.DataSize(), '/', progressbar.DataSize('max_value'),
            ' ', progressbar.Timer(),
            ' ', progressbar.AdaptiveETA(),
        ])

        def _callback(total_size, completed):
            if not hasattr(bar, "next_update"):
                if hasattr(bar, "maxval"):
                    bar.maxval = total_size
                else:
                    bar.max_value = total_size
                bar.start()
            bar.update(completed)

        def _finish():
            if hasattr(bar, "next_update"):
                return bar.finish()

        return progressinfo(callback=_callback, finish=_finish)
    else:
        return progressinfo(callback=None, finish=lambda: True)

def upload(progress_callback):

    for x in range(0, 300):
        time.sleep(1)
        progress_callback(300, x)


progress = get_progress_info()
upload(progress.callback)

https://github.com/tokland/youtube-upload/blob/master/youtube_upload/main.py#L63
https://github.com/tokland/youtube-upload/blob/master/youtube_upload/upload_video.py#L22

[wolph]

Not sure how or where it broke, but something is indeed not updating correctly there. I'm investigating the issue :)

[wolph]

Looking more closely at the code, the issue is that it's using next_update to decide what to do. That variable has been removed along the versions... I never expected anyone to depend on that but I'll add it again :)

For the time being the code should be fixable by simplifying it a bit:

import collections
import time
import progressbar

struct = collections.namedtuple

def get_progress_info():
    """Return a function callback to update the progressbar."""
    progressinfo = struct("ProgressInfo", ["callback", "finish"])

    if progressbar:
        bar = progressbar.ProgressBar(widgets=[
            progressbar.Percentage(),
            ' ', progressbar.Bar(),
            ' ', progressbar.FileTransferSpeed(),
            ' ', progressbar.DataSize(), '/', progressbar.DataSize('max_value'),
            ' ', progressbar.Timer(),
            ' ', progressbar.AdaptiveETA(),
        ])

        def _callback(total_size, completed):
            bar.max_value = total_size
            bar.update(completed)

        def _finish():
            return bar.finish()

        return progressinfo(callback=_callback, finish=_finish)
    else:
        return progressinfo(callback=None, finish=lambda: True)


def upload(progress_callback):
    for x in range(0, 300):
        time.sleep(1)
        progress_callback(300, x)


progress = get_progress_info()
upload(progress.callback)

[ilwsm]

Big thanks 👍 🥇

[wolph]

I've got a working patch ready on develop, I'm planning to put out a new release within the next couple of days.