Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup.py build dependency #5

Merged
merged 1 commit into from Sep 3, 2018
Merged

Fix setup.py build dependency #5

merged 1 commit into from Sep 3, 2018

Conversation

okeuday
Copy link
Contributor

@okeuday okeuday commented Sep 3, 2018

If you only want to use python setup.py build, this change makes its dependencies correct (similar to wolph/python-progressbar#171).

@wolph
Copy link
Owner

wolph commented Sep 3, 2018

Thanks for the fix :)
Better to be consistent indeed!

@wolph wolph merged commit eec70b2 into wolph:develop Sep 3, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9cdee71 on okeuday:develop into 5807e51 on WoLpH:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okeuday @wolph @coveralls