Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build docs with Python 3 #7

Merged
merged 1 commit into from May 15, 2019
Merged

Build docs with Python 3 #7

merged 1 commit into from May 15, 2019

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 13, 2019

Fixes #6

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 46b2192 on hroncok:py3docs into 6bbe13b on WoLpH:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 46b2192 on hroncok:py3docs into 6bbe13b on WoLpH:develop.

@wolph
Copy link
Owner

wolph commented May 15, 2019

I think the fix can be even simpler. I added this a long time ago when Sphinx didn't have a warning for non-local images such as build status. But it seems it's been integrated for some time now: sphinx-doc/sphinx#2466

I'll merge this in any case but I think I'll remove the entire bit of monkey patching :)

Thanks for the help as always Miro!

@wolph wolph merged commit 72309d2 into wolph:develop May 15, 2019
@hroncok hroncok deleted the py3docs branch May 15, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphinx 2.0 problems: BuildEnvironment has no attribute warn_node
3 participants
@hroncok @coveralls @wolph