Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Consolidate Python and Deb version #96

Closed
vpetersson opened this issue May 24, 2019 · 3 comments · Fixed by #118
Closed

Consolidate Python and Deb version #96

vpetersson opened this issue May 24, 2019 · 3 comments · Fixed by #118
Labels
enhancement New feature or request

Comments

@vpetersson
Copy link
Contributor

As it stands right now, we have two different versions of the agent (in the same repo):

  • The Python version
  • The Debian package version

let's consolidate the two are coupled right now anyway.

@vpetersson vpetersson added the enhancement New feature or request label May 24, 2019
@a-martynovich
Copy link
Contributor

took this

@a-martynovich
Copy link
Contributor

@vpetersson How do we manage versions?

In #51 you suggested to use short hash as part of version number. That means we'll have e.g. 0.1.5.aabbccdd instead of 0.1.5.9.

But the first three parts of the version (0.1.5) should still be managed manually. I changed 0.1.4 to 0.1.5 when I made #35 because it was sort of a major change.

I'm suggesting to put this manually managed version into a VERSION file at the root of the repo. This file will be used to build complete version string both for setuptools (setup.py) and debian package (changelog).

@vpetersson
Copy link
Contributor Author

Yes, managing the first three parts of the semantic versioning makes sense to do by hand. Having this managed in a file, such as VERSION, make sense to me.

a-martynovich added a commit to GreatFruitOmsk/agent that referenced this issue Jun 3, 2019
a-martynovich added a commit to GreatFruitOmsk/agent that referenced this issue Jun 3, 2019
a-martynovich added a commit to GreatFruitOmsk/agent that referenced this issue Jun 3, 2019
a-martynovich added a commit to GreatFruitOmsk/agent that referenced this issue Jun 3, 2019
a-martynovich added a commit to GreatFruitOmsk/agent that referenced this issue Jun 4, 2019
a-martynovich added a commit to GreatFruitOmsk/agent that referenced this issue Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants