-
Notifications
You must be signed in to change notification settings - Fork 2
Fix Django logging #154
Fix Django logging #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you could avoid duplicating code in prod.py and stage.py by moving it to base.py. Since it is executed only if SENTRY_DSN is set, one must know what he's doing if he's setting it in dev environment.
IMO we shouldn't manage the project behavior by setting/unsetting any environment vars. Instead we must explicitly set this in a settings file. As for environment vars - they are only for storage some values, not for management. @vpetersson wdyt? |
I have no strong opinion either way. It might be a bit more DRY to use That said, I disagree slightly about your point about env vars @rptrchv. They are fairly fundamental to 12 factor apps |
I'm strongly against code duplication (even though I may allow it myself sometimes). |
@a-martynovich I'm fully with you with regards to modifying VCS tracked files, but that isn't necessarily the case here. You can either modify the dev "profile" to not use Sentry, or modify both the production and staging profile to use it. |
Fixes #136 Done: - setup Sentry support - enabled it for prod and stage envs (only if SENTRY_DSN environment variable is available) - enabled errors output to console for all environments
c5c904e
to
5b6fbe9
Compare
@a-martynovich Got rid of that duplicated code |
well I'm happy with that. |
Fixes #136
Done: