Skip to content
This repository has been archived by the owner on Sep 16, 2022. It is now read-only.

Replace "Comment" with "Recommended Actions" #472

Merged

Conversation

a-martynovich
Copy link
Contributor

Closes #459
If the number of recommended actions is zero or undefined (if no portscan or firewall state) the column is empty.

Снимок экрана 2019-10-15 в 14 26 58

@vpetersson
Copy link
Contributor

@a-martynovich Could you use a Pill Badge for the number?

@a-martynovich
Copy link
Contributor Author

@vpetersson
image

@vpetersson
Copy link
Contributor

Perfect! Could you also change the 'select all' checkbox to the same style as the other page you just created a PR for. This has been bugging me for a long time.

@a-martynovich
Copy link
Contributor Author

@vpetersson It won't look the same because this table is rendered by DataTables JS component, and on the other page the table is in pure HTML. I can try to style the checkbox so that it looks more like a checkbox (because right now it's a button with a checkbox-like icon) or I can try to render it differently. Either way, it's not easy. Let's file an issue for it and decide when it going to be done, because I have lots of other stuff in this sprint.

@vpetersson
Copy link
Contributor

Fair enough. Ignore that request for now.

@rptrchv
Copy link
Contributor

rptrchv commented Oct 15, 2019

@vpetersson don't we need a link on the badge, pointing to the actions page?

@vpetersson
Copy link
Contributor

vpetersson commented Oct 15, 2019 via email

@a-martynovich
Copy link
Contributor Author

Made it a deep link.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants