Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added command line option to skip GRUB legacy bootloader #70

Merged
merged 2 commits into from
Feb 27, 2022
Merged

Added command line option to skip GRUB legacy bootloader #70

merged 2 commits into from
Feb 27, 2022

Conversation

marc1990
Copy link
Contributor

Add option to allow skipping grub process. As it result in hangs in some case: #41

@WaxyMocha WaxyMocha self-assigned this Feb 27, 2022
@WaxyMocha
Copy link
Member

Have you tested it? I can't boot the VM from it.

@marc1990
Copy link
Contributor Author

Have you tested it? I can't boot the VM from it.

Yes, I have on lenovo T470 and Ryzen 3000 system.
Can it be that the VM software has no UEFI support turn on?

BTW: I do expect the workaround to fail on old hardware.

@WaxyMocha
Copy link
Member

Huh, ok.
I'll try to dig up a pendrive and test it with real hardware.

@WaxyMocha
Copy link
Member

Also, could you add this option in gui? I'd look around line 28 in gui.py.

@WaxyMocha
Copy link
Member

Yup, it boots with UEFI

@marc1990
Copy link
Contributor Author

Also, could you add this option in gui? I'd look around line 28 in gui.py.

I just added that. (second commit)

@WaxyMocha
Copy link
Member

Looks good for me

@WaxyMocha WaxyMocha merged commit 4d4910b into WoeUSB:master Feb 27, 2022
This was referenced Mar 9, 2022
Open
Closed
WaxyMocha added a commit that referenced this pull request Feb 19, 2023
@WaxyMocha
Release 0.2.11
a43ce87 
Changes:
- #70; command line option to skip GRUB legacy bootloader
- #73; add -S to yay command
- #80; Swedish translation
- #84; Aesthetic corrections in Readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaxyMocha WaxyMocha WaxyMocha approved these changes

Assignees

@WaxyMocha WaxyMocha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marc1990 @WaxyMocha @marctopic