Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete section" processor doesn't kills invisible objects #459

Closed
Wohlstand opened this issue Oct 29, 2021 · 2 comments
Closed

"Delete section" processor doesn't kills invisible objects #459

Wohlstand opened this issue Oct 29, 2021 · 2 comments
Assignees
Labels
Projects

Comments

@Wohlstand
Copy link
Member

While investigating the issue that level makes crashes at SMBX2 game, the Editor side bug was found: https://github.com/WohlSoft/Moondust-Project/blob/master/Editor/main_window/level/level_sections_mods.cpp#L321-L326

The author of the original issue noticed that the "delete section" option was been used to remove sections and all items on them. However, there are was several invisible objects that weren't been deleted, and they caused the crash of the SMBX2 game.

After quick checking the Qt documentation: https://doc.qt.io/qt-5/qgraphicsscene.html#items-1 was found, that the items() call returns VISIBLE items only which is a direct source of the problem.

@Wohlstand Wohlstand added the bug label Oct 29, 2021
@Wohlstand Wohlstand self-assigned this Oct 29, 2021
@Wohlstand Wohlstand added this to To do / In work in Editor via automation Oct 29, 2021
@Wohlstand Wohlstand added bug and removed bug labels Oct 29, 2021
Wohlstand added a commit that referenced this issue Jun 10, 2022
Fixed dealing with invisible objects when clonning, rotating, deleting the section.

#459
@Wohlstand Wohlstand added the Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others. label Jun 10, 2022
@Wohlstand
Copy link
Member Author

The bug has been fixed, need to ask the reporter to test the updated Editor.

@Wohlstand
Copy link
Member Author

Wohlstand commented Jun 15, 2022

Quickly closing as there is no feedback from an original author for a while.

Editor automation moved this from To do / In work to Completed Jun 15, 2022
@Wohlstand Wohlstand removed the Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others. label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Editor
  
Completed
Development

No branches or pull requests

1 participant