Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake macro to force disable/enable module that doesn't comply with ZLib #39

Closed
knight-ryu12 opened this issue Nov 30, 2020 · 4 comments
Closed

CMake macro to force disable/enable module that doesn't comply with ZLib #39

knight-ryu12 opened this issue Nov 30, 2020 · 4 comments
Assignees
@Wohlstand
Labels
enhancement Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others.

Comments

@knight-ryu12
Copy link
Contributor

refer to #38, it'd be much easier to get it going.
@Wohlstand Wohlstand self-assigned this Nov 30, 2020
Wohlstand added a commit that referenced this issue Dec 1, 2020
@Wohlstand
Build: Print the binary license
2a1ca06 
When selecting using of various dependencies, show the license of binary while selecting dependencies.
#39
Wohlstand added a commit that referenced this issue Dec 1, 2020
@Wohlstand
Build: Added options to enforce specific license
eabf2f2 
Using of each flag will disable incompatible dependencies usage to guarantee specific license of the library.
#39
@Wohlstand Wohlstand added the Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others. label Dec 1, 2020
@Wohlstand
Copy link
Member

Done!

@knight-ryu12
Copy link
Contributor Author

I'd say return error whenever license conflict occurs.

@Wohlstand
Copy link
Member

Wohlstand commented Feb 6, 2021 •
edited

I'd say return error whenever license conflict occurs.

That just adds a headache to let users guess what they should disable to resolve the conflict, etc.

@Wohlstand
Copy link
Member

Anyway, the thing is done, if needed, can be improved later

@Wohlstand Wohlstand mentioned this issue May 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wohlstand Wohlstand

Labels
enhancement Need a test The fix / implementation needs some polishing and testing on a side of the reporter or by others.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wohlstand @knight-ryu12